Re: [PATCH 2/3] ARM: dts: BCM5301X: Linksys EA9500 add port 5 and port 7

From: Vivek Unune
Date: Wed Oct 07 2020 - 18:07:26 EST


On Wed, Oct 07, 2020 at 11:03:27PM +0200, Andrew Lunn wrote:
> On Wed, Oct 07, 2020 at 03:01:51PM -0400, Vivek Unune wrote:
> > Add port 5 and port 7 which are connected to gmac0 & 1 respectively
> > DSA driver will use port 5 as cpu port and this works as well.
>
> What port was used before this was added? The CPU port cannot be
> changed because it can break user space, the code which is configuring
> the master interface up.

Hi Andrew,

Port 8 was used before this. Factory firmware uses all three - 5, 7, 8
I'm aware that current implementation of DSA driver does support
multiple CPU ports and uses the first one that is detected. DSA works
for either of the CPU ports.

In case of the non-DSA switch driver, which is enabled by default in
OpenWrt. Port 8 configuration will not work, since the non-DSA driver
uses first gmac core i.e. eth0. But since gmac0 isn't connected to
port 5, it doesn't work.

This router is currently not enabled in Openwrt and it doesn't
generate a firmware for public consumtion. So I'm sure this won't
affect anyone. Albeit, I've been generating custom firmware [1] for
this so I can get feedback on these changes I'm submitting.

With this patch series, I plan to enable firmware for this router
and free me up myself from building custom images. Moreover, the
router will start getting regular updates.

Thanks,

Vivek

[1] https://forum.openwrt.org/t/build-for-linksys-ea9500/1817