Re: [PATCH] power: supply: max17040: Fix ptr to enum cast

From: Sebastian Reichel
Date: Thu Oct 08 2020 - 19:07:54 EST


Hi,

On Mon, Oct 05, 2020 at 11:00:38PM +0300, Iskren Chernev wrote:
> clang complains about casting pointers to smaller enum types.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Iskren Chernev <iskren.chernev@xxxxxxxxx>
> ---

Thanks, queued.

> P.S. I fixed a similar issue in v5, but it was in another patch, and the
> test robot only complains about the first issue, so I missed this one.
>
> There is a similar warning in ltc2941-battery-gauge, let me know if I
> should submit a fix for it as well.

Sure.

-- Sebastian

> drivers/power/supply/max17040_battery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/max17040_battery.c b/drivers/power/supply/max17040_battery.c
> index 1d7510a59295d..d956c67d51558 100644
> --- a/drivers/power/supply/max17040_battery.c
> +++ b/drivers/power/supply/max17040_battery.c
> @@ -247,7 +247,7 @@ static int max17040_get_of_data(struct max17040_chip *chip)
> {
> struct device *dev = &chip->client->dev;
> struct chip_data *data = &max17040_family[
> - (enum chip_id) of_device_get_match_data(dev)];
> + (uintptr_t) of_device_get_match_data(dev)];
> int rcomp_len;
> u8 rcomp[2];
>
>
> base-commit: f9d293364b452b651292ed3034dd06c57b1754d5
> --
> 2.28.0
>

Attachment: signature.asc
Description: PGP signature