Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig

[Greg KH]

On Fri, Oct 09, 2020 at 04:55:19AM +0000, Joel Stanley wrote:
> On Fri, 9 Oct 2020 at 04:45, Greg KH <greg@xxxxxxxxx> wrote:
> >
> > On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote:
> > > v2:
> > >  -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support.
> > > v1:
> > >  -Enable UHCI driver in aspeed_g5_defconfig.
> > >
> > > Signed-off-by: Ryan Chen <ryan_chen@xxxxxxxxxxxxxx>
> >
> > Why do you need this in a defconfig?
> 
> I would prefer configurations that are being used to be present in the
> defconfig so we can test it. I think this is a sensible change.

Then it needs to be described in the changelog, otherwise we have no
idea why this is happening :)

thanks,

greg k-h