Re: [PATCH] EDAC/amd64: Set proper family type for Family 19h Models 20h-2Fh

From: Borislav Petkov
Date: Fri Oct 09 2020 - 13:43:15 EST


On Fri, Oct 09, 2020 at 05:18:03PM +0000, Yazen Ghannam wrote:
> From: Yazen Ghannam <yazen.ghannam@xxxxxxx>
>
> AMD Family 19h Models 20h-2Fh use the same PCI IDs as Family 17h Models
> 70h-7Fh. The same family ops and number of channels also apply.
>
> Use the Family17h Model 70h family_type and ops for Family 19h Models
> 20h-2Fh. Update the controller name to match the system.
>
> Signed-off-by: Yazen Ghannam <yazen.ghannam@xxxxxxx>
> ---
> drivers/edac/amd64_edac.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
> index fcc08bbf6945..1362274d840b 100644
> --- a/drivers/edac/amd64_edac.c
> +++ b/drivers/edac/amd64_edac.c
> @@ -3385,6 +3385,12 @@ static struct amd64_family_type *per_family_init(struct amd64_pvt *pvt)
> break;
>
> case 0x19:
> + if (pvt->model >= 0x20 && pvt->model <= 0x2f) {
> + fam_type = &family_types[F17_M70H_CPUS];
> + pvt->ops = &family_types[F17_M70H_CPUS].ops;
> + fam_type->ctl_name = "F19h_M20h";
> + break;
> + }
> fam_type = &family_types[F19_CPUS];
> pvt->ops = &family_types[F19_CPUS].ops;
> family_types[F19_CPUS].ctl_name = "F19h";
> --

Applied, thanks.

It is too close to the merge window but this is enablement for new hw
which no one has yet so nothing should break.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette