Re: [PATCH V2 3/3] arm64: dts: imx8mp-evk: Correct WDOG_B pin configuration

From: Krzysztof Kozlowski
Date: Mon Oct 12 2020 - 09:05:51 EST


On Mon, Oct 12, 2020 at 08:44:02PM +0800, Anson Huang wrote:
> Different revision of i.MX8MP EVK boards may have different external
> pull up registor design, some are enabled while some are NOT, to make
> sure the WDOG_B pin works properly, better to enable internal pull up
> resistor. Since enabling internal pull up resistor is NOT harmful and
> having benefit of flexibility on different board design, just enable
> it for all i.MX8MP boards; And schmitt input is NOT necessary for this
> WDOG_B output pin, so remove it; Open drain outputs provide more
> flexibility to a designer as they can be pulled-up to any voltage found
> in the system, so enable it as well.
>
> Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
> ---
> Changes since V1:
> - Provide more explanation of removing schmitt input and enabling open drain in commit msg.
> ---
> arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

Best regards,
Krzysztof