Re: [PATCH] spi: imx: Revert "spi: imx: enable runtime pm support"

From: Mark Brown
Date: Mon Oct 12 2020 - 09:43:32 EST


On Mon, Oct 12, 2020 at 03:28:21PM +0200, Sascha Hauer wrote:
> On Mon, Oct 12, 2020 at 12:59:34PM +0200, Christian Eggers wrote:

> > What is the benefit of controlling the SPI clock with runtime PM instead of
> > doing it manually?

> The clocks are reconfigured less frequently with pm_runtime. Especially
> when enabling/disabling PLLs are involved pm_runtime can increase
> performance.

In particular pm_runtime has support for deferring the actual disable so
if you get lots of activity in quick succession you don't actually ever
disable things until the activity stops. This can really help reduce
overhead.

Attachment: signature.asc
Description: PGP signature