Re: [PATCH 2/2] nvmem: core: add OF_RECONFIG handler for nvmem cells

[kernel test robot]

Hi Michael,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.9 next-20201013]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Michael-Auchter/nvmem-add-DT-overlay-support-for-cells/20201015-054223
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 37187df45af7d28d27b5c130c23f407ca9dbefa2
config: x86_64-randconfig-a006-20201014 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project e7b4feea8e1bf520b34ad8c116abab6677344b74)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/a3191767e8e4e0480e36126ce93e6ab41ab6f498
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Michael-Auchter/nvmem-add-DT-overlay-support-for-cells/20201015-054223
        git checkout a3191767e8e4e0480e36126ce93e6ab41ab6f498
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> drivers/nvmem/core.c:1701:42: error: use of undeclared identifier 'nvmem_of_notifier'; did you mean 'nvmem_notifier'?
                   WARN_ON(of_reconfig_notifier_register(&nvmem_of_notifier));
                                                          ^~~~~~~~~~~~~~~~~
                                                          nvmem_notifier
   include/asm-generic/bug.h:119:25: note: expanded from macro 'WARN_ON'
           int __ret_warn_on = !!(condition);                              \
                                  ^
   drivers/nvmem/core.c:67:31: note: 'nvmem_notifier' declared here
   static BLOCKING_NOTIFIER_HEAD(nvmem_notifier);
                                 ^
   drivers/nvmem/core.c:1709:44: error: use of undeclared identifier 'nvmem_of_notifier'; did you mean 'nvmem_notifier'?
                   WARN_ON(of_reconfig_notifier_unregister(&nvmem_of_notifier));
                                                            ^~~~~~~~~~~~~~~~~
                                                            nvmem_notifier
   include/asm-generic/bug.h:119:25: note: expanded from macro 'WARN_ON'
           int __ret_warn_on = !!(condition);                              \
                                  ^
   drivers/nvmem/core.c:67:31: note: 'nvmem_notifier' declared here
   static BLOCKING_NOTIFIER_HEAD(nvmem_notifier);
                                 ^
   2 errors generated.

vim +1701 drivers/nvmem/core.c

  1691	
  1692	static int __init nvmem_init(void)
  1693	{
  1694		int rval;
  1695	
  1696		rval = bus_register(&nvmem_bus_type);
  1697		if (rval)
  1698			return rval;
  1699	
  1700		if (IS_ENABLED(CONFIG_OF_DYNAMIC))
> 1701			WARN_ON(of_reconfig_notifier_register(&nvmem_of_notifier));
  1702	
  1703		return 0;
  1704	}
  1705	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip