Re: [PATCH][next] io_uring: fix flags check for the REQ_F_WORK_INITIALIZED setting

From: Jens Axboe
Date: Thu Oct 15 2020 - 09:12:22 EST


On 10/15/20 5:55 AM, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Currently the check for REQ_F_WORK_INITIALIZED is always true because
> the | operator is being used. I believe this check should be checking
> if the bit is set using the & operator.

It should - I folded in the incremental from Pavel. This just meant that
we took the slow and safe path, but it obviously should be an AND here.

--
Jens Axboe