Re: [PATCH] powerpc: force inlining of csum_partial() to avoid multiple csum_partial() with GCC10

From: Christophe Leroy
Date: Thu Oct 15 2020 - 09:32:10 EST




Le 15/10/2020 à 15:25, Segher Boessenkool a écrit :
Hi!

On Thu, Oct 15, 2020 at 10:52:20AM +0000, Christophe Leroy wrote:
With gcc9 I get:

<snip>

With gcc10 I get:

<snip>

gcc10 defines multiple versions of csum_partial() which are just
an unconditionnal branch to __csum_partial().

It doesn't inline it, yes.

Could you open a GCC PR for this please?

Sure.

I also have get_order() 75 times in my vmlinux, all the same as the following:

c0016790 <get_order>:
c0016790: 38 63 ff ff addi r3,r3,-1
c0016794: 54 63 a3 3e rlwinm r3,r3,20,12,31
c0016798: 7c 63 00 34 cntlzw r3,r3
c001679c: 20 63 00 20 subfic r3,r3,32
c00167a0: 4e 80 00 20 blr

Christophe