Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled

From: Daniel Vetter
Date: Thu Oct 15 2020 - 11:23:07 EST


On Wed, Oct 14, 2020 at 09:48:43AM +0800, Kever Yang wrote:
> Hi Maintainers,
>
>     Does this patch ready to merge?

Would maybe be good to get some acks from other drivers using this, then
Sandy can push to drm-misc-next.
-Daniel
>
> On 2020/7/7 下午7:25, Sandy Huang wrote:
> > don't mask possible_crtcs if remote-point is disabled.
> >
> > Signed-off-by: Sandy Huang <hjc@xxxxxxxxxxxxxx>
> > ---
> > drivers/gpu/drm/drm_of.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
> > index fdb05fbf72a0..565f05f5f11b 100644
> > --- a/drivers/gpu/drm/drm_of.c
> > +++ b/drivers/gpu/drm/drm_of.c
> > @@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev,
> > uint32_t possible_crtcs = 0;
> > for_each_endpoint_of_node(port, ep) {
> > + if (!of_device_is_available(ep))
> > + continue;
> > +
> > remote_port = of_graph_get_remote_port(ep);
> > if (!remote_port) {
> > of_node_put(ep);
>
> Looks good to me.
>
>
> Reviewed-by: Kever Yang <kever.yang@xxxxxxxxxxxxxx>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch