Re: [PATCH] zram: Fix __zram_bvec_{read,write}() locking order

From: Sebastian Andrzej Siewior
Date: Mon Oct 19 2020 - 11:29:14 EST


On 2020-10-19 12:13:53 [+0200], Peter Zijlstra wrote:
>
> Mikhail reported a lockdep spat detailing how __zram_bvec_read() and
> __zram_bvec_write() use zstrm->lock and zspage->lock in opposite order.
>
> Reported-by: Mikhail Gavrilov <mikhail.v.gavrilov@xxxxxxxxx>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
> Tested-by: Mikhail Gavrilov <mikhail.v.gavrilov@xxxxxxxxx>

We have the same patch in RT. I didn't submit it with the other
local-lock patches because this splat pops up once pin_tag() is made a
sleeping lock. I missed the part where migrate_read_lock() can be a
lock. So:

Acked-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>

Sebastian