Re: [PATCH net] net: Have netpoll bring-up DSA management interface

From: Vladimir Oltean
Date: Mon Oct 19 2020 - 17:19:21 EST


On Mon, Oct 19, 2020 at 02:03:40PM -0700, Florian Fainelli wrote:
> > Completely crazy and outlandish idea, I know, but what's wrong with
> > doing this in DSA?
>
> I really do not have a problem with that approach however other stacked
> devices like 802.1Q do not do that. It certainly scales a lot better to
> do this within DSA rather than sprinkling DSA specific knowledge
> throughout the network stack. Maybe for "configuration less" stacked
> devices such as DSA, 802.1Q (bridge ports?), bond etc. it would be
> acceptable to ensure that the lower device is always brought up?

For upper interfaces with more than one lower (bridge, bond) I'm not so
sure. For uppers with a single lower (DSA, 8021q), it's pretty much a
no-brainer to me. Question is, where to code this? I think it's ok to
leave it in DSA, then 8021q could copy it as well if there was a need.