Re: [PATCH 05/29] arm64: dts: amlogic: meson-g12: Set FL-adj property value

From: Neil Armstrong
Date: Tue Oct 20 2020 - 09:06:32 EST


Hi Serge,

On 20/10/2020 13:59, Serge Semin wrote:
> In accordance with the DWC USB3 bindings the property is supposed to have
> uint32 type. It's erroneous from the DT schema and driver points of view
> to declare it as boolean. As Neil suggested set it to 0x20 so not break
> the platform and to make the dtbs checker happy.
>
> Link: https://lore.kernel.org/linux-usb/20201010224121.12672-16-Sergey.Semin@xxxxxxxxxxxxxxxxxxxx/
> Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> index 1e83ec5b8c91..3033ab2be1ff 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> @@ -2380,7 +2380,7 @@ dwc3: usb@ff500000 {
> interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
> dr_mode = "host";
> snps,dis_u2_susphy_quirk;
> - snps,quirk-frame-length-adjustment;
> + snps,quirk-frame-length-adjustment = <0x20>;
> snps,parkmode-disable-ss-quirk;
> };
> };
>

You were faster than me !

Reviewed-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>