Re: [PATCH] pci: remove unneeded break

From: Bjorn Helgaas
Date: Tue Oct 20 2020 - 12:03:03 EST


On Mon, Oct 19, 2020 at 12:02:49PM -0700, trix@xxxxxxxxxx wrote:
> From: Tom Rix <trix@xxxxxxxxxx>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>

Applied with Linus' reviewed-by to pci/misc for v5.10, thanks!

> ---
> drivers/pci/controller/pci-v3-semi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pci-v3-semi.c b/drivers/pci/controller/pci-v3-semi.c
> index 1f54334f09f7..154a5398633c 100644
> --- a/drivers/pci/controller/pci-v3-semi.c
> +++ b/drivers/pci/controller/pci-v3-semi.c
> @@ -658,7 +658,6 @@ static int v3_get_dma_range_config(struct v3_pci *v3,
> default:
> dev_err(v3->dev, "illegal dma memory chunk size\n");
> return -EINVAL;
> - break;
> }
> val |= V3_PCI_MAP_M_REG_EN | V3_PCI_MAP_M_ENABLE;
> *pci_map = val;
> --
> 2.18.1
>