Re: [PATCH 1/2] cifs: convert to add_to_page_cache()

[Steve French]

Other than the unnecessary split line which Christoph pointed out, looks fine.

You can add my Reviewed--by: Steve French <stfrench@xxxxxxxxxxxxx>

On Tue, Oct 20, 2020 at 5:10 AM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> > +     rc = add_to_page_cache(page, mapping,
> > +                            page->index, gfp);
>
> This trivially fits onto a single line.



-- 
Thanks,

Steve