Re: [PATCH v5 2/2] leds: mt6360: Add LED driver for MT6360

[Jacek Anaszewski]

On 10/20/20 8:44 AM, Gene Chen wrote:
> Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx> 於 2020年10月9日 週五 上午5:51寫道：
> > Hi Gene,
> >
> > On 10/7/20 3:42 AM, Gene Chen wrote:
> > > From: Gene Chen <gene_chen@xxxxxxxxxxx>
> > >
> > > Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode,
> > > 3-channel RGB LED support Register/Flash/Breath Mode, and 1-channel for
> > > moonlight LED.
> > >
> > > Signed-off-by: Gene Chen <gene_chen@xxxxxxxxxxx>
> > > ---
> > >    drivers/leds/Kconfig       |  12 +
> > >    drivers/leds/Makefile      |   1 +
> > >    drivers/leds/leds-mt6360.c | 783 +++++++++++++++++++++++++++++++++++++++++++++
> > >    3 files changed, 796 insertions(+)
> > >    create mode 100644 drivers/leds/leds-mt6360.c
> > >
> > > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> > > index 1c181df..c7192dd 100644
> > > --- a/drivers/leds/Kconfig
> > > +++ b/drivers/leds/Kconfig
> > > @@ -271,6 +271,18 @@ config LEDS_MT6323
> > >          This option enables support for on-chip LED drivers found on
> > >          Mediatek MT6323 PMIC.
> > >
> > > +config LEDS_MT6360
> > > +     tristate "LED Support for Mediatek MT6360 PMIC"
> > > +     depends on LEDS_CLASS_FLASH && OF
> > > +     depends on LEDS_CLASS_MULTICOLOR
> >
> > Since CONFIG_LED_CLASS_MULTICOLOR can be turned off you need to have
> > below instead:
> >
> > depends on LEDS_CLASS_MULTICOLOR || !!LEDS_CLASS_MULTICOLOR
> >
> > Unless you want to prevent enabling the driver without RGB LED,
> > but that does not seem to be reasonable at first glance.
>
> May I change to "select LEDS_CLASS_MULTICOLOR"?
> I suppose RGB always use multicolor mode.

You will also have moonlight LED that will not need multicolor
framework. Is it somehow troublesome to keep "depends on"?

--
Best regards,
Jacek Anaszewski