Re: [PATCH] mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it

[Matthieu Baerts]

Hi Geert,

On 21/10/2020 11:43, Geert Uytterhoeven wrote:
> Hi Jakub,
>
> On Wed, Oct 21, 2020 at 5:56 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
> > On Tue, 20 Oct 2020 11:26:34 +0200 Matthieu Baerts wrote:
> > > On 20/10/2020 09:38, Geert Uytterhoeven wrote:
> > > > MPTCP_IPV6 selects IPV6, thus enabling an optional feature the user may
> > > > not want to enable.  Fix this by making MPTCP_IPV6 depend on IPV6, like
> > > > is done for all other IPv6 features.
> > >
> > > Here again, the intension was to select IPv6 from MPTCP but I understand
> > > the issue: if we enable MPTCP, we will select IPV6 as well by default.
> > > Maybe not what we want on some embedded devices with very limited memory
> > > where IPV6 is already off. We should instead enable MPTCP_IPV6 only if
> > > IPV6=y. LGTM then!
> > >
> > > Reviewed-by: Matthieu Baerts <matthieu.baerts@xxxxxxxxxxxx>
> >
> > Applied, thanks!
>
> My apologies, this fails for the CONFIG_IPV6=m and CONFIG_MPTCP=y
> case:

Good point, MPTCP cannot be compiled as a module (like TCP). It should 
then depends on IPV6=y. I thought it would be the case.

Do you want me to send a patch or do you already have one?

Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net