Re: [PATCH] arm64: dts: imx8m: use generic name for tmu

From: Krzysztof Kozlowski
Date: Thu Oct 22 2020 - 05:06:55 EST


On Thu, Oct 22, 2020 at 03:21:18PM +0800, peng.fan@xxxxxxx wrote:
> From: Peng Fan <peng.fan@xxxxxxx>
>
> Per devicetree specification, generic names are recommended
> to be used, such as temperature-sensor.
>
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> ---
> arch/arm64/boot/dts/freescale/imx8mm.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/imx8mn.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index b83f400def8b..327f1d44ced9 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -404,7 +404,7 @@ gpio5: gpio@30240000 {
> gpio-ranges = <&iomuxc 0 119 30>;
> };
>
> - tmu: tmu@30260000 {
> + tmu: temperature-sensor@30260000 {

No, TMU is not a temperature-sensor. It does much more. TMU is quite
generic name for this class of device.

Best regards,
Krzysztof