Re: [PATCH] firmware/dmi: Include product_sku info to modalias

[Kai-Chuan Hsieh]

Hello Jean,

There are multiple product skus share the same product name, like 
clamshell and 2-in-1 for Latitude series.
Both of them have 3-axis accelerator, but rotation is only disable for 
clamshell model.
Originally, it should be descriminated by chassis_type, but found that 
chassis_type is not trustful.
https://github.com/systemd/systemd/pull/17084#issuecomment-706931881
Therefore, I would like to propose a change to include the product_sku 
for applying customized configuration easier.

Thanks,
KaiChuan

On 10/22/20 8:42 PM, Jean Delvare wrote:
> Hi Kai-Chuan,
>
> On Thu, 22 Oct 2020 14:40:47 +0800, kaichuan.hsieh@xxxxxxxxxxxxx wrote:
> > From: Kai-Chuan Hsieh <kaichuan.hsieh@xxxxxxxxxxxxx>
> >
> > Some Dell platforms rely on modalias to customize configuration,
> > the product sku can be more specific for the hardware.
> >
> > Add product_sku to modalias for better utilization.
>
> Do you have an actual use case for this already, or is it a theoretical
> concern?