Re: [Outreachy kernel][PATCH 0/5] drm/amdgpu: Replace snprintf() with sysfs_emit

From: Daniel Vetter
Date: Thu Oct 22 2020 - 10:13:56 EST


On Thu, Oct 22, 2020 at 07:07:50PM +0530, Sumera Priyadarsini wrote:
> Using snprintf() for show() methods holds the risk of buffer overrun
> as snprintf() does not know the PAGE_SIZE maximum of the temporary
> buffer used to output sysfs content.
>
> This patchset is a series of Coccinelle cleanups across the staging
> directory to convert snprintf with scnprintf in the relevant files.

I think you need to edit your template here since this is now drivers/gpu,
not staging :-)
-Daniel

>
> Sumera Priyadarsini (5):
> gpu: drm: amdgpu: Replace snprintf() with sysfs_emit()
> gpu: drm: amdgpu: Replace snprintf() with sysfs_emit()
> gpu: drm: amdgpu: Replace snprintf() with sysfs_emit()
> gpu: drm: amdgpu: Replace snprintf() with sysfs_emit()
> gpu: drm: amdgpu: Replace snprintf() with sysfs_emit()
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 ++++----
> drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 4 ++--
> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 ++--
> 5 files changed, 10 insertions(+), 10 deletions(-)
>
> --
> 2.25.1
>

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch