Re: [PATCH] lib: add basic KUnit test for lib/math

From: Andy Shevchenko
Date: Thu Oct 22 2020 - 15:11:51 EST


On Thu, Oct 22, 2020 at 10:10:38PM +0300, Andy Shevchenko wrote:
> On Thu, Oct 22, 2020 at 09:26:45AM -0700, Daniel Latypov wrote:
> > On Thu, Oct 22, 2020 at 8:06 AM Andy Shevchenko
> > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > > On Wed, Oct 21, 2020 at 10:47:50AM -0700, Daniel Latypov wrote:

...

> > > Summarize this, please create usable documentation first.
> >
> > Sounds good.
> > I'm generally wary people not reading the docs, and of documentation
> > examples becoming bitrotted faster than actual code.
> > But so far KUnit seems to be doing relatively well on both fronts.
>
> Dunno. As I told, I have created first unit test based on documentation (okay,
> I looked at the code, but you may read this as ratio was 90% doc / 10% existing
> code).

Side note: some cases are not described in doc and produced "interesting"
results that I have to look a lot into KUnit Python wrapper to fix bugs in it.

You may find my patches in the KUnit mailing list.

--
With Best Regards,
Andy Shevchenko