Re: [PATCH RFC v2] checkpatch: extend attributes check to handle more patterns

From: Dwaipayan Ray
Date: Fri Oct 23 2020 - 17:10:32 EST


On Sat, Oct 24, 2020 at 2:34 AM Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> On Sat, 2020-10-24 at 02:27 +0530, Dwaipayan Ray wrote:
> > Also I tried the pattern attr =~ s/^_*(.*)_*$/$1/
> > for trimming the _ earlier. I think it doesn't trim the
> > trailing underscores in the suffix as (.*) captures everything greedily.
> >
> > Is the iterative one perhaps okay instead?
> > while($attr =~ s/(.*)_$/$1/) {}
>
> Then perhaps
>
> $curr_attr =~ s/^_+//; $curr_attr =~ s/_+$//;
>
Okay thanks!
I will send in a new version when everything looks good
and tested.

Regards,
Dwaipayan.