Re: [PATCH v5 2/2] PM / devfreq: Add governor attribute flag for specifc sysfs nodes

From: Chanwoo Choi
Date: Sun Oct 25 2020 - 21:48:47 EST


On 10/26/20 1:30 AM, Dmitry Osipenko wrote:
> 23.10.2020 13:26, Chanwoo Choi пишет:
>> @@ -909,6 +915,8 @@ struct devfreq *devfreq_add_device(struct device *dev,
>> goto err_init;
>> }
>>
>> + create_sysfs_files(devfreq, governor);
>> +
>> devfreq->governor = governor;
>> err = devfreq->governor->event_handler(devfreq, DEVFREQ_GOV_START,
>> NULL);
>
> Shouldn't sysfs be created *after* GOV_START? This is inconsistent with
> governor_store().
>
>

Good point. Thanks for the review. I'll edit it.

--
Best Regards,
Chanwoo Choi
Samsung Electronics