RE: [PATCH v3] usb: cdns3: Variable 'length' set but not used

From: Peter Chen
Date: Wed Oct 28 2020 - 18:13:42 EST



>
> >
> >> Peter,
> >>
> >> It looks like you missed the " [PATCH v3] usb: cdns3: Variable
> >> 'length' set but not used"
> >>
> >> It's quite important because compiler complains for this when I use W=1.
> >>
> >
> >Pawel, it is the bug-fix, and located at branch: for-usb-fixes.
>
> But I can't see it in this branch:
>
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kern
> el.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fpeter.chen%2Fusb.git%2Flo
> g%2F%3Fh%3Dfor-usb-fixes%26qt%3Dgrep%26q%3Dcdns3&data=04%7C
> 01%7Cpeter.chen%40nxp.com%7Cc49c80ded3ec4bae70aa08d87b120467%7C
> 686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637394664604902329%7
> CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBT
> iI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=jtcT0U8ZptlBSwST00%2B
> bMtCQDZDr%2B3PNMm69RrZWgDs%3D&reserved=0
>
> I can see there only: usb: cdns3: Rids of duplicate error message.
>

Thanks for notifying it, I have updated it.

Peter

> >
> >> Thanks,
> >> Pawel
> >>
> >> >> >
> >> >> > A gentle ping.
> >> >> >
> >> >> > I assume that you should add this and the rest overdue cdsn3
> >> >> > patches as first to you ci-for-usb-next branch.
> >> >> > Am I right?
> >> >> >
> >> >>
> >> >> Hi Pawel,
> >> >>
> >> >> I queued them locally, and I waited for v5.10-rc1 which was out
> >> >> yesterday, then I will apply them, and add cdns3 patches to my
> >> >> kernel.org branch. Will update you these two days.
> >> >>
> >> >> Peter
> >> >
> >> >Hi Pawel,
> >> >
> >> >The cdns3 -next patches pushed to: for-usb-next; cdns3 -fixes
> >> >patches pushed
> >> to: for-usb-fixes.
> >> >The git is:
> >> >git://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git
> >> >
> >> >Currently, I only pushed three of your patches, would you please
> >> >review my
> >> patches, thanks.
> >> >
> >> >Peter