Re: [PATCH] seqlock: avoid -Wshadow warnings

From: Peter Zijlstra
Date: Wed Oct 28 2020 - 22:00:17 EST


On Wed, Oct 28, 2020 at 12:34:10AM +0100, Arnd Bergmann wrote:
> On Mon, Oct 26, 2020 at 5:58 PM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> >
> > On Mon, Oct 26, 2020 at 05:50:38PM +0100, Arnd Bergmann wrote:
> >
> > > - unsigned seq; \
> > > + unsigned __seq; \
> >
> > > - unsigned seq = __read_seqcount_begin(s); \
> > > + unsigned _seq = __read_seqcount_begin(s); \
> >
> > > - unsigned seq = __seqcount_sequence(s); \
> > > + unsigned __seq = __seqcount_sequence(s); \
> >
> > Can we have a consistent number of leading '_' ?
>
> Not really ;-)

Duh.. ok, I'll take it as is.