Re: [PATCH] regmap: provide regmap_assign_bits()

From: Mark Brown
Date: Thu Oct 29 2020 - 11:19:05 EST


On Mon, Oct 26, 2020 at 04:10:15PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
>
> Add another bits helper to regmap API: this one sets given bits if value
> is true and clears them if it's false.

What's the use case?

> +static inline int regmap_assign_bits(struct regmap *map, unsigned int reg,
> + unsigned int bits, bool value)

I don't have a great suggestion but this naming feels prone to confusion
with _update_bits().

Attachment: signature.asc
Description: PGP signature