Re: [PATCH 07/11 v2] livepatch: Trigger WARNING if livepatch function fails due to recursion

From: Steven Rostedt
Date: Mon Nov 02 2020 - 11:56:46 EST


On Mon, 2 Nov 2020 15:41:09 +0100
Petr Mladek <pmladek@xxxxxxxx> wrote:

> On Fri 2020-10-30 17:31:49, Steven Rostedt wrote:
> > From: "Steven Rostedt (VMware)" <rostedt@xxxxxxxxxxx>
> >
> > If for some reason a function is called that triggers the recursion
> > detection of live patching, trigger a warning. By not executing the live
> > patch code, it is possible that the old unpatched function will be called
> > placing the system into an unknown state.
> >
> > Link: https://lore.kernel.org/r/20201029145709.GD16774@alley
> >
> > Cc: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> > Cc: Jiri Kosina <jikos@xxxxxxxxxx>
> > Cc: Miroslav Benes <mbenes@xxxxxxx>
> > Cc: Joe Lawrence <joe.lawrence@xxxxxxxxxx>
> > Cc: live-patching@xxxxxxxxxxxxxxx
> > Suggested-by: Petr Mladek <pmladek@xxxxxxxx>
>
> It has actually been first suggested by Miroslav. He might want
> to take the fame and eventual shame ;-)

I'll switch suggested by to Miroslav.

>
> > Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
>
> Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

Thanks!

-- Steve