Re: [PATCH v7 2/4] net: phy: Add 5GBASER interface mode

From: Florian Fainelli
Date: Mon Nov 02 2020 - 21:12:36 EST




On 11/2/2020 5:34 PM, Pavana Sharma wrote:
>> How many times have i asked for you to add kerneldoc for this new
>> value? How many times have you not done so?
>
> I have added kerneldoc comment for the new value added.
>
>> NACK.
>
>> If you don't understand a comment, please ask.
>
> Ok, explain what do you expect by that comment.

What Andrew wants you to do is add a comment like this:

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/include/linux/phy.h#n88
--
Florian