Re: [PATCH 1/4] erofs: fix setting up pcluster for temporary pages

From: Chao Yu
Date: Tue Nov 03 2020 - 20:45:03 EST


On 2020/11/4 9:11, Gao Xiang wrote:
On Wed, Nov 04, 2020 at 09:05:56AM +0800, Chao Yu wrote:
On 2020/10/22 22:57, Gao Xiang wrote:
From: Gao Xiang <hsiangkao@xxxxxxxxxx>

pcluster should be only set up for all managed pages instead of
temporary pages. Since it currently uses page->mapping to identify,
the impact is minor for now.

Fixes: 5ddcee1f3a1c ("erofs: get rid of __stagingpage_alloc helper")
Cc: <stable@xxxxxxxxxxxxxxx> # 5.5+
Signed-off-by: Gao Xiang <hsiangkao@xxxxxxxxxx>

Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx>

Thanks, I've also added a note to the commit message like this,
"
[ Update: Vladimir reported the kernel log becomes polluted
because PAGE_FLAGS_CHECK_AT_FREE flag(s) set if the page
allocation debug option is enabled. ]
"
Will apply all of this to -fixes branch.

Thanks for noticing that, looks fine to me.

Thanks,


Thanks,
Gao Xiang


Thanks,


.