Re: [PATCH] ARM: dts: exynos: Assign a fixed index to mmc devices on exynos4412 based ODROID boards

[Markus Reichl]

Hi Marek,

Am 04.11.20 um 13:25 schrieb Marek Szyprowski:
> Hi Markus,
>
> On 04.11.2020 11:25, Markus Reichl wrote:
> > Recently introduced async probe on mmc devices can shuffle block IDs.
> > Pin them to fixed values to ease booting in evironments where UUIDs ar not practical.
> > Use newly introduced aliases for mmcblk devices from [1].
> >
> > [1]
> > https://patchwork.kernel.org/patch/11747669/
> >
> > Signed-off-by: Markus Reichl <m.reichl@xxxxxxxxxxxxx>
> > ---
> >   arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 5 +++++
> >   1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > index a5c1ce1e396c..aa10d5bc7e1c 100644
> > --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > @@ -13,6 +13,11 @@
> >   #include "exynos-mfc-reserved-memory.dtsi"
> >   
> >   / {
> > +	aliases {
> > +		mmc0 = &sdhci_2;
> > +		mmc1 = &mshc_0;
>
> Like in the OdroidXU3-family patch, I would use 0 for the eMMC (mshc_0)
> and 2 for the SD-card (sdhci_2).

This would break present and long standing  boot ordering in mainline, which is
mmcblk0 = SD-card and
mmcblk1 = eMMC

Still desired?

> > +	};
> > +
> >   	chosen {
> >   		stdout-path = &serial_1;
> >   	};
>
> Best regards

Gruß,
--
Markus Reichl