Re: [PATCH 06/12] net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header

From: Andrew Lunn
Date: Wed Nov 04 2020 - 08:33:59 EST


On Wed, Nov 04, 2020 at 09:06:04AM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'ndev' not described in 'am65_cpsw_timer_set'
> drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'est_new' not described in 'am65_cpsw_timer_set'
>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> Cc: Ivan Khoronzhuk <ivan.khoronzhuk@xxxxxxxxxx>
> Cc: "Gustavo A. R. Silva" <gustavoars@xxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

I _think_ these have got missed so far in the various cleanup passes
because of missing COMPILE_TEST. I've been adding that as part of
fixing these warnings. When your respin, could you add that as well?

Thanks
Andrew