Re: [PATCH 0/3] gpio: pcie-idio-24: Fix IRQ handling

From: William Breathitt Gray
Date: Wed Nov 04 2020 - 10:45:52 EST


On Wed, Nov 04, 2020 at 04:24:52PM +0100, Arnaud de Turckheim wrote:
> This patch set fixes the irq_mask/irq_unmask functions and enables the
> PLX PEX8311 local interrupts.
>
> With the current version of the driver, gpiomon (from libgpiod) or a
> poll(2) on the sysfs value are not working. According to
> /proc/interrupts, there is no interruption triggered.
> The main issue is that the local interrupts are not forwarded by the
> PEX8311 to the PCI.
>
> There is also two bugs:
> - The IRQ mask is not correctly updated when unmasking an
> interruption.
> - The COS Enable Register value is not correctly updated when
> masking/unmasking an interruption.
>
> It seems this problems exist since the initial commit.
>
> Arnaud de Turckheim (3):
> gpio: pcie-idio-24: Fix irq mask when masking
> gpio: pcie-idio-24: Fix IRQ Enable Register value
> gpio: pcie-idio-24: Enable PEX8311 interrupts
>
> drivers/gpio/gpio-pcie-idio-24.c | 62 ++++++++++++++++++++++++++++----
> 1 file changed, 56 insertions(+), 6 deletions(-)
>
> --
> 2.25.1
>

This patchset looks good to me and fixes several fundamental bugs. I'm
going to reply to each patch individually to give my Reviewed-by tags
for the benefit of those picking up the patches.

Thanks!

William Breathitt Gray

Attachment: signature.asc
Description: PGP signature