Re: [PATCH 09/12] net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours

[drt]

On 2020-11-04 05:38, Andrew Lunn wrote:
> On Wed, Nov 04, 2020 at 09:06:07AM +0000, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> >  from drivers/net/ethernet/ibm/ibmvnic.c:35:
> >  inlined from ‘handle_vpd_rsp’ at 
> > drivers/net/ethernet/ibm/ibmvnic.c:4124:3:
> >  drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter 
> > or member 'hdr_field' not described in 'build_hdr_data'
> >  drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter 
> > or member 'skb' not described in 'build_hdr_data'
> >  drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter 
> > or member 'hdr_len' not described in 'build_hdr_data'
> >  drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter 
> > or member 'hdr_data' not described in 'build_hdr_data'
> >  drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter 
> > or member 'hdr_field' not described in 'create_hdr_descs'
> >  drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter 
> > or member 'hdr_data' not described in 'create_hdr_descs'
> >  drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter 
> > or member 'len' not described in 'create_hdr_descs'
> >  drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter 
> > or member 'hdr_len' not described in 'create_hdr_descs'
> >  drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter 
> > or member 'scrq_arr' not described in 'create_hdr_descs'
> >  drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter 
> > or member 'txbuff' not described in 'build_hdr_descs_arr'
> >  drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter 
> > or member 'num_entries' not described in 'build_hdr_descs_arr'
> >  drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter 
> > or member 'hdr_field' not described in 'build_hdr_descs_arr'
> >  drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter 
> > or member 'adapter' not described in 'do_change_param_reset'
> >  drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter 
> > or member 'rwi' not described in 'do_change_param_reset'
> >  drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter 
> > or member 'reset_state' not described in 'do_change_param_reset'
> >  drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter 
> > or member 'adapter' not described in 'do_reset'
> >  drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter 
> > or member 'rwi' not described in 'do_reset'
> >  drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter 
> > or member 'reset_state' not described in 'do_reset'
> >
> > Cc: Dany Madden <drt@xxxxxxxxxxxxx>
> > Cc: Lijun Pan <ljp@xxxxxxxxxxxxx>
> > Cc: Sukadev Bhattiprolu <sukadev@xxxxxxxxxxxxx>
> > Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> > Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> > Cc: Paul Mackerras <paulus@xxxxxxxxx>
> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> > Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> > Cc: Santiago Leon <santi_leon@xxxxxxxxx>
> > Cc: Thomas Falcon <tlfalcon@xxxxxxxxxxxxxxxxxx>
> > Cc: John Allen <jallen@xxxxxxxxxxxxxxxxxx>
> > Cc: netdev@xxxxxxxxxxxxxxx
> > Cc: linuxppc-dev@xxxxxxxxxxxxxxxx
> > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
>
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Reviewed-by: Dany Madden <drt@xxxxxxxxxxxxx>

Thanks, Lee.
Dany
>     Andrew