Re: [PATCH v2 net-next 1/3] ptp: idt82p33: add adjphase support

From: Jakub Kicinski
Date: Wed Nov 04 2020 - 18:49:25 EST


On Wed, 4 Nov 2020 18:13:44 -0500 min.li.xe@xxxxxxxxxxx wrote:
> From: Min Li <min.li.xe@xxxxxxxxxxx>
>
> Add idt82p33_adjphase() to support PHC write phase mode.
>
> Changes since v1:
> -Fix broken build

One more trivial thing detected by checkpatch:

ERROR: trailing whitespace
#41: FILE: drivers/ptp/ptp_idt82p33.c:138:
+^Ioffset = _OFFSET(regaddr);^I$

Please add Richard's Acked-by tags to the commit messages.

Also are you sure the last patch is okay? Richard suggested it's not
worth the risk AFAIU.