Re: [PATCH net-next v2 08/19] net: phy: mscc: remove the use of .ack_interrupt()

From: Vladimir Oltean
Date: Wed Nov 04 2020 - 19:07:50 EST


On Sun, Nov 01, 2020 at 02:51:03PM +0200, Ioana Ciornei wrote:
> From: Ioana Ciornei <ioana.ciornei@xxxxxxx>
>
> In preparation of removing the .ack_interrupt() callback, we must replace
> its occurrences (aka phy_clear_interrupt), from the 2 places where it is
> called from (phy_enable_interrupts and phy_disable_interrupts), with
> equivalent functionality.
>
> This means that clearing interrupts now becomes something that the PHY
> driver is responsible of doing, before enabling interrupts and after
> clearing them. Make this driver follow the new contract.
>
> Cc: Antoine Tenart <atenart@xxxxxxxxxx>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@xxxxxxx>
> ---

Tested-by: Vladimir Oltean <olteanv@xxxxxxxxx> # VSC8514