Re: [PATCH 1/4] clk: sifive: Extract prci core to common base

From: Stephen Boyd
Date: Wed Nov 04 2020 - 21:45:48 EST


Quoting Zong Li (2020-10-16 02:18:23)
> Extract common core of prci driver to an independent file, it could
> allow other chips to reuse it. Separate SoCs-dependent code 'fu540'
> from prci core, then we can easily add 'fu740' later.

Please indicate if there are any functional changes or this is just code
movement.

>
> Signed-off-by: Zong Li <zong.li@xxxxxxxxxx>
> ---
> drivers/clk/sifive/Makefile | 2 +
> drivers/clk/sifive/fu540-prci.c | 586 +------------------------------
> drivers/clk/sifive/fu540-prci.h | 21 ++
> drivers/clk/sifive/sifive-prci.c | 409 +++++++++++++++++++++
> drivers/clk/sifive/sifive-prci.h | 201 +++++++++++

How much of this is a copy/pastes? Can you generate patches with
format-patch -M -C to try to find copies and renames?

> 5 files changed, 652 insertions(+), 567 deletions(-)
> create mode 100644 drivers/clk/sifive/fu540-prci.h
> create mode 100644 drivers/clk/sifive/sifive-prci.c
> create mode 100644 drivers/clk/sifive/sifive-prci.h
>