Re: [PATCH] clk: fsl-sai: fix memory leak

[Michael Walle]

Am 2020-11-05 01:29, schrieb Stephen Boyd:
> Quoting Michael Walle (2020-11-01 10:48:18)
> > diff --git a/drivers/clk/clk-fsl-sai.c b/drivers/clk/clk-fsl-sai.c
> > index 0221180a4dd7..1e81c8d8a6fd 100644
> > --- a/drivers/clk/clk-fsl-sai.c
> > +++ b/drivers/clk/clk-fsl-sai.c
> > @@ -68,9 +68,20 @@ static int fsl_sai_clk_probe(struct platform_device 
> > *pdev)
> >         if (IS_ERR(hw))
> >                 return PTR_ERR(hw);
> >
> > +       platform_set_drvdata(pdev, hw);
> > +
> >         return devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get, 
> > hw);
> >  }
> >
> > +static int fsl_sai_clk_remove(struct platform_device *pdev)
> > +{
> > +       struct clk_hw *hw = platform_get_drvdata(pdev);
> > +
> > +       clk_hw_unregister_composite(hw);
>
> Should we add a devm_clk_hw_register_composite() API and use it here?
> That way we don't need a remove function and devm can be used
> throughout.

Can do. But does adding a devm_ function qualify for the -stable branch?
Or should I expect to have exactly this patch as a backport there then?

-michael