Re: [PATCH net-next] net: x25_asy: Delete the x25_asy driver

From: Xie He
Date: Thu Nov 05 2020 - 14:35:17 EST


On Thu, Nov 5, 2020 at 1:10 AM David Laight <David.Laight@xxxxxxxxxx> wrote:
>
> > This driver transports LAPB (X.25 link layer) frames over TTY links.
>
> I don't remember any requests to run LAPB over anything other
> than synchronous links when I was writing LAPB implementation(s)
> back in the mid 1980's.
>
> If you need to run 'comms over async uart links' there
> are better options.
>
> I wonder what the actual use case was?

I think this driver was just for experimental purposes. According to
the author's comment at the beginning of x25_asy.c, this driver didn't
implement FCS (frame check sequence), which was required by CCITT's
standard. So I think this driver was not suitable for real-world use
anyway.