Re: Kunit fixes update for Linux 5.10-rc3

[Shuah Khan]

On 11/5/20 1:02 PM, Linus Torvalds wrote:
> On Thu, Nov 5, 2020 at 8:55 AM Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> wrote:
> >    .../kunit/test_data/test_config_printk_time.log    | Bin 1584 -> 1605 bytes
> >    .../test_data/test_interrupted_tap_output.log      | Bin 1982 -> 2003 bytes
> >    .../test_data/test_kernel_panic_interrupt.log      | Bin 1321 -> 1342 bytes
> >    .../kunit/test_data/test_multiple_prefixes.log     | Bin 1832 -> 1861
>
> This diffstat is a bit annoying.
>
> And the reason is that we have
>
>      [torvalds@ryzen linux]$ cat tools/testing/kunit/.gitattributes
>      test_data/* binary
>
> iow, you're telling git that everything in that test_data directory is
> binary blobs. Which isn't actually true.
>
> This isn't new, but it was just more noticeable this time around.
>
> That binary marker comes from commit afc63da64f1e ("kunit:
> kunit_parser: make parser more robust") and I'm not really seeing the
> reason for it.

You are right. It appears there is no need to add these binary blobs.
Brendan and I discussed this and he will send a fix to remove the blobs
and redo the test output. In other words fix commit afc63da64f1e.

Sorry for not catching this earlier.

thanks,
-- Shuah