Re: [PATCH bpf v4 2/2] selftest/bpf: Test bpf_probe_read_user_str() strips trailing bytes after NUL

From: Song Liu
Date: Thu Nov 05 2020 - 19:20:19 EST




> On Nov 5, 2020, at 4:06 PM, Daniel Xu <dxu@xxxxxxxxx> wrote:
>
> Previously, bpf_probe_read_user_str() could potentially overcopy the
> trailing bytes after the NUL due to how do_strncpy_from_user() does the
> copy in long-sized strides. The issue has been fixed in the previous
> commit.
>
> This commit adds a selftest that ensures we don't regress
> bpf_probe_read_user_str() again.
>
> Signed-off-by: Daniel Xu <dxu@xxxxxxxxx>

LGTM!

Acked-by: Song Liu <songliubraving@xxxxxx>

[...]