RE: [PATCH] net/dsa: remove unused macros to tame gcc warning

From: David Laight
Date: Fri Nov 06 2020 - 04:24:16 EST


From: Joe Perches
> Sent: 06 November 2020 06:36
>
> On Fri, 2020-11-06 at 13:37 +0800, Alex Shi wrote:
> > There are some macros unused, they causes much gcc warnings. Let's
> > remove them to tame gcc.
>
> I believe these to be essentially poor warnings.

Indeed.

One 'solution' is to move the #defines into an included .h file.

> Aren't these warnings generated only when adding W=2 to the make
> command line?
>
> Perhaps it's better to move the warning to level 3

I'd move then to level 9999999999.

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)