Re: [PATCH] arm64/smp: Move rcu_cpu_starting() earlier

From: Qian Cai
Date: Fri Nov 06 2020 - 07:49:07 EST


On Fri, 2020-11-06 at 10:37 +0000, Will Deacon wrote:
> > diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> > index 09c96f57818c..10729d2d6084 100644
> > --- a/arch/arm64/kernel/smp.c
> > +++ b/arch/arm64/kernel/smp.c
> > @@ -421,6 +421,8 @@ void cpu_die_early(void)
> >
> > update_cpu_boot_status(CPU_STUCK_IN_KERNEL);
> >
> > + rcu_report_dead(cpu);
>
> I think this is in the wrong place, see:
>
> https://lore.kernel.org/r/20201106103602.9849-1-will@xxxxxxxxxx
>
> which seems to fix the problem for me.
Ah, I had not realized that cpu_psci_cpu_die() could no return. Your patchset
looks good to me.