[tip: ras/core] x86/mce: Correct the detection of invalid notifier priorities

From: tip-bot2 for Zhen Lei
Date: Fri Nov 06 2020 - 13:34:50 EST


The following commit has been merged into the ras/core branch of tip:

Commit-ID: 15af36596ae305aefc8c502c2d3e8c58221709eb
Gitweb: https://git.kernel.org/tip/15af36596ae305aefc8c502c2d3e8c58221709eb
Author: Zhen Lei <thunder.leizhen@xxxxxxxxxx>
AuthorDate: Fri, 06 Nov 2020 22:12:16 +08:00
Committer: Borislav Petkov <bp@xxxxxxx>
CommitterDate: Fri, 06 Nov 2020 19:02:48 +01:00

x86/mce: Correct the detection of invalid notifier priorities

Commit

c9c6d216ed28 ("x86/mce: Rename "first" function as "early"")

changed the enumeration of MCE notifier priorities. Correct the check
for notifier priorities to cover the new range.

[ bp: Rewrite commit message, remove superfluous brackets in
conditional. ]

Fixes: c9c6d216ed28 ("x86/mce: Rename "first" function as "early"")
Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx>
Signed-off-by: Borislav Petkov <bp@xxxxxxx>
Link: https://lkml.kernel.org/r/20201106141216.2062-2-thunder.leizhen@xxxxxxxxxx
---
arch/x86/include/asm/mce.h | 3 ++-
arch/x86/kernel/cpu/mce/core.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/x86/include/asm/mce.h b/arch/x86/include/asm/mce.h
index a0f1478..fc25c88 100644
--- a/arch/x86/include/asm/mce.h
+++ b/arch/x86/include/asm/mce.h
@@ -177,7 +177,8 @@ enum mce_notifier_prios {
MCE_PRIO_EXTLOG,
MCE_PRIO_UC,
MCE_PRIO_EARLY,
- MCE_PRIO_CEC
+ MCE_PRIO_CEC,
+ MCE_PRIO_HIGHEST = MCE_PRIO_CEC
};

struct notifier_block;
diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
index 888248a..ccac4c2 100644
--- a/arch/x86/kernel/cpu/mce/core.c
+++ b/arch/x86/kernel/cpu/mce/core.c
@@ -162,7 +162,8 @@ EXPORT_SYMBOL_GPL(mce_log);

void mce_register_decode_chain(struct notifier_block *nb)
{
- if (WARN_ON(nb->priority > MCE_PRIO_MCELOG && nb->priority < MCE_PRIO_EDAC))
+ if (WARN_ON(nb->priority < MCE_PRIO_LOWEST ||
+ nb->priority > MCE_PRIO_HIGHEST))
return;

blocking_notifier_chain_register(&x86_mce_decoder_chain, nb);