Re: [Sound-open-firmware] linux-next: Tree for Nov 6 (sound/soc/sof/sof-pci-dev.o)

[Pierre-Louis Bossart]

> on x86_64:
>
> ld: sound/soc/sof/sof-pci-dev.o: in function `sof_pci_probe':
> sof-pci-dev.c:(.text+0x5c): undefined reference to `snd_intel_dsp_driver_probe'
>
>
> Full randconfig file is attached.

Nice catch, thanks Randy! Looks like we put the select 
SND_INTEL_DSP_CONFIG in the wrong place, it's not dependent on the 
HDaudio link being selected. Clearly a bug we've had for a while.

The diff below makes the error go away but I have to run it past folks 
who are already enjoying their week-end. Will follow-up next week with a 
proper fix.

diff --git a/sound/soc/sof/intel/Kconfig b/sound/soc/sof/intel/Kconfig
index a066e08860cb..5bfc2f8b13b9 100644
--- a/sound/soc/sof/intel/Kconfig
+++ b/sound/soc/sof/intel/Kconfig
@@ -271,6 +271,7 @@ config SND_SOC_SOF_JASPERLAKE

 config SND_SOC_SOF_HDA_COMMON
        tristate
+       select SND_INTEL_DSP_CONFIG
        select SND_SOC_SOF_INTEL_COMMON
        select SND_SOC_SOF_HDA_LINK_BASELINE
        help
@@ -330,7 +331,6 @@ config SND_SOC_SOF_HDA
        tristate
        select SND_HDA_EXT_CORE if SND_SOC_SOF_HDA_LINK
        select SND_SOC_HDAC_HDA if SND_SOC_SOF_HDA_AUDIO_CODEC
-       select SND_INTEL_DSP_CONFIG
        help
          This option is not user-selectable but automagically handled by
          'select' statements at a higher level