Re: [PATCH 00/19] Add generic user_landing tracking

From: Andy Lutomirski
Date: Sun Nov 08 2020 - 14:08:03 EST


On Sat, Nov 7, 2020 at 9:17 PM Dmitry Safonov <dima@xxxxxxxxxx> wrote:
>
> Started from discussion [1], where was noted that currently a couple of
> architectures support mremap() for vdso/sigpage, but not munmap().
> If an application maps something on the ex-place of vdso/sigpage,
> later after processing signal it will land there (good luck!)
>
> Patches set is based on linux-next (next-20201106) and it depends on
> changes in x86/cleanups (those reclaim TIF_IA32/TIF_X32) and also
> on my changes in akpm (fixing several mremap() issues).
>
> Logically, the patches set divides on:
> - patch 1: cleanup for patches in x86/cleanups
> - patches 2-11: cleanups for arch_setup_additional_pages()

I like these cleanups, although I think you should stop using terms
like "new-born". A task being exec'd is not newborn at all -- it's in
the middle of a transformation.

--Andy