Re: [PATCH] x86/platform/uv: drop last traces of uv_flush_tlb_others

From: Steve Wahl
Date: Mon Nov 09 2020 - 11:01:10 EST


Acked-by: Steve Wahl <steve.wahl@xxxxxxx>

On Mon, Nov 09, 2020 at 10:36:53AM +0100, Jiri Slaby wrote:
> Commit 39297dde7390 ("x86/platform/uv: Remove UV BAU TLB Shootdown
> Handler") removed uv_flush_tlb_others. Its declaration was removed also
> from asm/uv/uv.h. But only for the CONFIG_X86_UV=y case. The inline
> definition (!X86_UV case) is still in place.
>
> So remove this implementation with everything what was added to support
> uv_flush_tlb_others:
> * include of asm/tlbflush.h
> * forward declarations of struct cpumask, mm_struct, and flush_tlb_info
>
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> Cc: Mike Travis <mike.travis@xxxxxxx>
> Cc: Dimitri Sivanich <dimitri.sivanich@xxxxxxx>
> Cc: Steve Wahl <steve.wahl@xxxxxxx>
> Cc: Russ Anderson <russ.anderson@xxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Borislav Petkov <bp@xxxxxxxxx>
> Cc: x86@xxxxxxxxxx
> Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
> ---
> arch/x86/include/asm/uv/uv.h | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/arch/x86/include/asm/uv/uv.h b/arch/x86/include/asm/uv/uv.h
> index 172d3e4a9e4b..648eb23fe7f0 100644
> --- a/arch/x86/include/asm/uv/uv.h
> +++ b/arch/x86/include/asm/uv/uv.h
> @@ -2,14 +2,8 @@
> #ifndef _ASM_X86_UV_UV_H
> #define _ASM_X86_UV_UV_H
>
> -#include <asm/tlbflush.h>
> -
> enum uv_system_type {UV_NONE, UV_LEGACY_APIC, UV_X2APIC};
>
> -struct cpumask;
> -struct mm_struct;
> -struct flush_tlb_info;
> -
> #ifdef CONFIG_X86_UV
> #include <linux/efi.h>
>
> @@ -44,10 +38,6 @@ static inline int is_uv_system(void) { return 0; }
> static inline int is_uv_hubbed(int uv) { return 0; }
> static inline void uv_cpu_init(void) { }
> static inline void uv_system_init(void) { }
> -static inline const struct cpumask *
> -uv_flush_tlb_others(const struct cpumask *cpumask,
> - const struct flush_tlb_info *info)
> -{ return cpumask; }
>
> #endif /* X86_UV */
>
> --
> 2.29.2
>

--
Steve Wahl, Hewlett Packard Enterprise