Re: [PATCH net-next v1] net: phy: spi_ks8995: Do not overwrite SPI mode flags

[Sven Van Asbroeck]

On Mon, Nov 9, 2020 at 2:49 PM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> Did you check to see if there is a help to set just the mode without
> changing any of the other bits?

Absolutely, but it doesn't exist, AFAIK.

It would be great if client spi drivers would use a helper function like
that. The spi bus driver on my platform (imx ecspi) was recently changed
upstream, which means SPI_CS_HIGH is now always set, irrespective
of the actual chip select polarity. This change breaks every single spi
driver which "plows over" the spi->mode flags. And there are quite
a few...

Sven