Re: [RFC PATCH 4/7] preempt/dynamic: Provide cond_resched() and might_resched() static calls

From: Peter Zijlstra
Date: Tue Nov 10 2020 - 05:48:41 EST


On Tue, Nov 10, 2020 at 11:39:09AM +0100, Peter Zijlstra wrote:
> Subject: static_call: EXPORT_STATIC_CALL_TRAMP()
> From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Date: Tue Nov 10 11:37:48 CET 2020
>
> For when we want to allow modules to call the static_call() but not
> change it.
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
> ---
> @@ -269,6 +281,9 @@ static inline int static_call_text_reser
> return 0;
> }
>
> +#define EXPORT_STATIC_CALL_TRAMP(name)
> +#define EXPORT_STATIC_CALL_TRAMP_GPL(name)
> +
> #define EXPORT_STATIC_CALL(name) EXPORT_SYMBOL(STATIC_CALL_KEY(name))
> #define EXPORT_STATIC_CALL_GPL(name) EXPORT_SYMBOL_GPL(STATIC_CALL_KEY(name))

Hurmph, this hunk is wrong, it should export the KEY in both cases :/

That's unfortunate but unavoidable I suppose.