Re: [PATCH v2 4/4] remoteproc: sysmon: Improve error messages

[rishabhb]

On 2020-11-04 20:50, Bjorn Andersson wrote:
> Improve the style of a few of the error messages printed by the sysmon
> implementation and fix the copy-pasted shutdown error in the send-event
> function.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> ---
>
> Changes since v1:
> - New patch
>
>  drivers/remoteproc/qcom_sysmon.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/remoteproc/qcom_sysmon.c 
> b/drivers/remoteproc/qcom_sysmon.c
> index 1c42f00010d3..47683932512a 100644
> --- a/drivers/remoteproc/qcom_sysmon.c
> +++ b/drivers/remoteproc/qcom_sysmon.c
> @@ -352,9 +352,9 @@ static bool ssctl_request_shutdown(struct
> qcom_sysmon *sysmon)
>
>  	ret = qmi_txn_wait(&txn, 5 * HZ);
>  	if (ret < 0) {
> -		dev_err(sysmon->dev, "failed receiving QMI response\n");
> +		dev_err(sysmon->dev, "timeout waiting for shutdown response\n");
>  	} else if (resp.resp.result) {
> -		dev_err(sysmon->dev, "shutdown request failed\n");
> +		dev_err(sysmon->dev, "shutdown request rejected\n");
>  	} else {
>  		dev_dbg(sysmon->dev, "shutdown request completed\n");
>  		acked = true;
> @@ -397,18 +397,18 @@ static void ssctl_send_event(struct qcom_sysmon 
> *sysmon,
>  			       SSCTL_SUBSYS_EVENT_REQ, 40,
>  			       ssctl_subsys_event_req_ei, &req);
>  	if (ret < 0) {
> -		dev_err(sysmon->dev, "failed to send shutdown request\n");
> +		dev_err(sysmon->dev, "failed to send subsystem event\n");
>  		qmi_txn_cancel(&txn);
>  		return;
>  	}
>
>  	ret = qmi_txn_wait(&txn, 5 * HZ);
>  	if (ret < 0)
> -		dev_err(sysmon->dev, "failed receiving QMI response\n");
> +		dev_err(sysmon->dev, "timeout waiting for subsystem event 
> response\n");
>  	else if (resp.resp.result)
> -		dev_err(sysmon->dev, "ssr event send failed\n");
> +		dev_err(sysmon->dev, "subsystem event rejected\n");
>  	else
> -		dev_dbg(sysmon->dev, "ssr event send completed\n");
> +		dev_dbg(sysmon->dev, "subsystem event accepted\n");
>  }
>
>  /**
Reviewed-by: Rishabh Bhatnagar <rishabhb@xxxxxxxxxxxxxx>