Re: [PATCH V2 net-next 09/11] net: hns3: add support for EQ/CQ mode configuration

From: Jakub Kicinski
Date: Tue Nov 10 2020 - 20:25:29 EST


On Mon, 9 Nov 2020 11:22:37 +0800 Huazhong Tan wrote:
> For device whose version is above V3(include V3), the GL can
> select EQ or CQ mode, so adds support for it.
>
> In CQ mode, the coalesced timer will restart upon new completion,
> while in EQ mode, the timer will not restart.
>
> Signed-off-by: Huazhong Tan <tanhuazhong@xxxxxxxxxx>

Let's see if I understand - in CQ mode the timer is restarted very time
new frame gets received/transmitted? IOW for a continuous stream of
frames it will only generate an interrupt once it reaches max_frames?

I think that if you need such a configuration knob we should add this as
an option to the official ethtool -c/-C interface, now that we have the
ability to extend the netlink API.